ChefKissInc / NootedRed

The AMD Vega iGPU support patch kext. No commercial use.
https://chefkissinc.github.io/applehax/nootedred/
Other
1.72k stars 880 forks source link

Image & video hardware decoding/encoding (hardware DRM, VCN) support #28

Open VisualEhrmanntraut opened 1 year ago

VisualEhrmanntraut commented 1 year ago

@jalavoui Well the DRM-unlocking code is just UnfairGVA from WhateverGreen. So if it doesn’t work, it’s likely their fault

ezxpro commented 1 year ago

Is this DRM-related black screen mentioned by @jalavoui something that only happens when playing DRMed content or is there aa possibility this could happen at boot too?

I sometimes get a black screen at boot, when that happens nothing seems to fix it, I have to remove nooted red and reinstall Big Sur again. It works fine until I get this black screen, then it will never boot with nooted red again. Curiously this also happened to some fresh installs I made in the last several days. It boots fine once or two times, then once I get the black screen it no longer boots normally.

jalavoui commented 1 year ago

ezxpro what you describe is a known bug. delete /var/db/.com.apple.iokit.graphics and reboot (plz mark this as off-topic)

Kanepan commented 1 year ago

Can this be fixed? Looking forward to solving this problem, thank you Sorry, I posted it again

aleelmaitro commented 1 year ago

Hello @ChefKissInc ... I have made a successful publication with a Ryzen 5 3400G, and I find the problem that the decoding does not work... Is there a boot argument, fake-id or something else to fix it or do we just have to wait? I take this opportunity to congratulate you and thank you for your work.... Captura de pantalla 2023-08-24 a la(s) 21 49 48 Captura de pantalla 2023-08-24 a la(s) 21 51 40 Captura de pantalla 2023-08-24 a la(s) 21 54 08 Captura de pantalla 2023-08-24 a la(s) 21 55 14 Captura de Pantalla 2023-08-25 a la(s) 09 22 18 Captura de Pantalla 2023-08-25 a la(s) 09 22 50 Captura de Pantalla 2023-08-25 a la(s) 09 23 11 Captura de Pantalla 2023-08-25 a la(s) 09 23 29 Captura de Pantalla 2023-08-25 a la(s) 09 23 42 Captura de Pantalla 2023-08-25 a la(s) 09 24 04 Captura de Pantalla 2023-08-25 a la(s) 09 24 20 Captura de Pantalla 2023-08-25 a la(s) 09 24 35 Captura de Pantalla 2023-08-25 a la(s) 09 24 46 Captura de Pantalla 2023-08-25 a la(s) 09 24 58

VisualEhrmanntraut commented 1 year ago

Be patient, I'm the only dev!

aleelmaitro commented 1 year ago

@ChefKissInc I am pleased to report that the decoder seems to be working!!!!! The modifications I have made are: VRAM in BIOS: Auto boot-args: -nredvcn Captura de pantalla 2023-08-26 a la(s) 18 58 17

aleelmaitro commented 1 year ago

Well... now when I open Google Chrome the PC restarts...

AxerErnest19 commented 1 year ago

Well... now when I open Google Chrome the PC restarts... You have to disable hardware acceleration from Chrome options or from the terminal https://nootinc.github.io/nred#chrome-chromium-based-browsers-and-apps-like-sublime-text-cause-graphical-artefacts-amongst-other-problems

aleelmaitro commented 1 year ago

Bueno… ahora cuando abro Google Chrome la PC se reinicia… Hay que desactivar la aceleración por hardware desde las opciones de Chrome o desde la terminal https://nootinc.github.io/nred#chrome-chromium-based-browsers-and -aplicaciones-como-texto-sublime-causan-artefactos-gráficos-entre-otros-problemas

Yes... I just applied it and it works... Thank you very much for the information...

aleelmaitro commented 1 year ago

@ChefKissInc ¡¡¡Me complace informarles que el decodificador parece estar funcionando!!!!! Las modificaciones que he realizado son: VRAM en BIOS: Auto boot-args: -nredvcn Captura de pantalla 2023-08-26 a la(s) 18 58 17

Regarding the decoder, Hackintool and VDADecoderCheck say that it is working, but "VideoProc Converter 4K" says that it is not supported Captura de pantalla 2023-08-26 a la(s) 21 35 26

VisualEhrmanntraut commented 1 year ago

As the firmware used is correct, and the logic in macOS is correct, and AppleGVA is seemingly almost patched fully, I have no idea what is still up with this. Maybe there is an issue with the rest of the firmware since we don’t replace anything other than VCN.

VisualEhrmanntraut commented 1 year ago

I have unlocked the conversation for discussion of functionality after new firmware injection. Please don't spam with screenshots or asking for EFIs; I will lock it again.

jalavoui commented 1 year ago

can someone with renoir try play a movie on kodi - it uses h264 decoding. by some unknown reason long time decoding crashes the driver on raven

pokewizardSAM commented 1 year ago

can someone with renoir try play a movie on kodi - it uses h264 decoding. by some unknown reason long time decoding crashes the driver on raven

i am pretty new to kodi , installed it just 2 min ago , i idont know if i should have mentoined anything else so please tell me if i left something

results of playng a h.264 encoded file , a h.265 file also works fine Screenshot 2023-09-10 at 6 54 23 AM Screenshot 2023-09-10 at 6 54 35 AM Screenshot 2023-09-10 at 6 54 51 AM Screenshot 2023-09-10 at 6 56 02 AM Screenshot 2023-09-10 at 6 56 50 AM

jalavoui commented 1 year ago

yes short play works fine. problem is if you let the movie play till end it will hang on raven. to test decode you need to add to boot args -nredvcn. you will get a driver crash log in library that will show vcn packets hang

VisualEhrmanntraut commented 1 year ago

One issue is that it doesn't change the capability of how much resolution is supported. VCN 1 supports smaller resolution than VCN 2

VisualEhrmanntraut commented 1 year ago

After further analysis the issue is more complicated than just the VA bundle. For instance, the Metal Accelerator Shared User Client which has different platform function indices in X6000 vs X5000. In addition, the "SML" class, which amongst other functions, dictates whether there's SAMU, VCN, VCE, etc. Furthermore, the Video Context class of the accelerator. There might be more I missed in my analysis. Don't know for sure about the dependency of the Accelerator Shared class, but the VA bundle definitely uses it from what I can tell.

aleelmaitro commented 1 year ago

Hello everyone... I saw the tag that says "Help Wanted"... I have no knowledge of programming, but I am willing to carry out tests with your proper instruction... If this is useful to you, then let me know...

VisualEhrmanntraut commented 1 year ago

I have a testing device of my own, lol.

aleelmaitro commented 1 year ago

I want to confirm that I was successful in installing macOS Sonoma 14.0 (23A344) on Ryzentosh with Integrated Graphics Processor: AMD Ryzen 5 3400G 3.7GHz Motherboard: ASUS A320M-K Bootloader: OpenCore 0.9.5 Note: VDA Decoder claims to be failing, but I have Metal 3 support and very smooth 4K video playback...

Hotinosin commented 1 year ago

I want to confirm that I was successful in installing Ventura 13.5.2 on Ryzentosh with Integrated Graphics Processor: AMD Ryzen 5 4300G 3.8GHz Motherboard: A520 Bootloader: OpenCore 0.9.5 Connect: DP Note: Hachintool display VDA Decoder claims to be failing, but 4K H.264 works good, very smooth Thx

VisualEhrmanntraut commented 8 months ago

Existing code has been removed because it's broken. Part of a bigger end goal called "The Update".

itsyecoder commented 7 months ago

I am using this on an AMD Ryzen 7 5800u. I believe this issue is causing crashes on apps such as Firefox, ultimaker cura, and onedrive. Is there a command to put into boot-arg or anyway to make these apps somewhat useful till this is fixed? (plz mark as off topic)

VisualEhrmanntraut commented 7 months ago

https://docs.github.com/en/issues/tracking-your-work-with-issues/about-issues