Script optimization - Githubissues

ChefKissInc / NootedRed

The AMD Vega iGPU support patch kext. No commercial use.

https://chefkissinc.github.io/applehax/nootedred/

Other

1.66k stars 806 forks source link

Script optimization #36

Closed mingww64 closed 1 year ago

mingww64 commented 1 year ago

Scripts/FwGen.sh: run without Xcode environment, backup the kern_fw.cpp to kern_fw.cpp.old.

.gitignore: ignore backup

Scripts/GenerateFirmware.py

replace os.walk with pathlib.Path, which is more modern and looks cleaner.
avoid frequent I/O operations by saving data to list first and then writing them altogether.

VisualEhrmanntraut commented 1 year ago

For one, this project is not intended to be built without Xcode and there's no use making a backup of kern_fw.cpp. Additionally, this is not a performance-critical file, it only gets ran once in the build process, and you messed up the formatting of the code, not to mention the grammatical error(s). Furthermore, merging is blocked because you have made an unsigned commit. Therefore, your PR shall not be merged. With that in mind, this PR has been Reviewed-by: Visual 30368284+ChefKissInc@users.noreply.github.com Signed-off-by: Visual 30368284+ChefKissInc@users.noreply.github.com

mingww64 commented 1 year ago

Thanks for letting me know all of the reasons anyway. I should be more prepared before shitting on other's repositories...