search

Chemellia / AtomicGraphNets.jl

Atomic graph models for molecules and crystals in Julia
MIT License
62 stars 10 forks source link

Update for Flux 0.13 #103

Closed mcabbott closed 2 years ago

mcabbott commented 2 years ago

This package fails in Flux's downstream tests, as Flux.params is no longer exported:

1150
backward pass: Error During Test at /home/runner/work/Flux.jl/Flux.jl/downstream/test/model_tests.jl:48
[1151](https://github.com/FluxML/Flux.jl/runs/5459853360?check_suite_focus=true#step:6:1151)
  Got exception outside of a @test
[1152](https://github.com/FluxML/Flux.jl/runs/5459853360?check_suite_focus=true#step:6:1152)
  UndefVarError: params not defined
[1153](https://github.com/FluxML/Flux.jl/runs/5459853360?check_suite_focus=true#step:6:1153)
  Stacktrace:
[1154](https://github.com/FluxML/Flux.jl/runs/5459853360?check_suite_focus=true#step:6:1154)
    [1] macro expansion
[1155](https://github.com/FluxML/Flux.jl/runs/5459853360?check_suite_focus=true#step:6:1155)
      @ ~/work/Flux.jl/Flux.jl/downstream/test/model_tests.jl:52 [inlined]

If this is qualified (and a version tagged) it'll be easier to see if anything else breaks it.

rkurchin commented 2 years ago

Thanks for letting me know. Is there a replacement for params? In the stable docs (v0.12.9), params is still used...or is the suggested fix here just to either explicitly call/import Flux.params?

(Just want to clarify before mucking around with anything :) )

mcabbott commented 2 years ago

It's still there, just not exported, as too many different packages think that's a useful name. So (as you say) you must either qualify the name, or import it.