search

Chemellia / ChemistryFeaturization.jl

Interface package for featurizing atomic structures
https://chemistryfeaturization.chemellia.org/dev/
MIT License
41 stars 14 forks source link

Remove MKL from build #113

Closed DhairyaLGandhi closed 2 years ago

DhairyaLGandhi commented 3 years ago

cc @thazhemadam

This aims to get CI on macOS to not rely on the MKL Conda hack which makes the build pretty complex.

codecov-commenter commented 3 years ago

Codecov Report

Merging #113 (bf690aa) into main (fb0018d) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #113   +/-   ##
=======================================
  Coverage   80.81%   80.81%           
=======================================
  Files          12       12           
  Lines         318      318           
=======================================
  Hits          257      257           
  Misses         61       61

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fb0018d...bf690aa. Read the comment docs.

thazhemadam commented 3 years ago

Another weird thing is how Windows CIs also automatically fail when this hack is removed. Windows doesn't even use .dylibs!

DhairyaLGandhi commented 3 years ago

Windows and Linux found the variable. I wonder what macOS wants. Seems like windows can't find numpy.

rkurchin commented 2 years ago

I fixed the mkl issue in #131 so I'm going to close this