search

Chemellia / ChemistryFeaturization.jl

Interface package for featurizing atomic structures
https://chemistryfeaturization.chemellia.org/dev/
MIT License
41 stars 14 forks source link

Migrate from LightGraphs to Graphs.jl #123

Closed simonschoelly closed 2 years ago

simonschoelly commented 2 years ago

As you my know, development of LightGraphs has been moved to Graphs.jl. The announcement can be found here.

This PR migrates this package to Graphs.jl. It would also probably be good to create a new version, so that the same procedure can be done with AtomicGraphNets.jl.

codecov[bot] commented 2 years ago

Codecov Report

Merging #123 (86c123b) into main (09cff80) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #123   +/-   ##
=======================================
  Coverage   87.42%   87.42%           
=======================================
  Files          17       17           
  Lines         493      493           
=======================================
  Hits          431      431           
  Misses         62       62
Impacted Files Coverage Δ
src/atoms/atomgraph.jl 77.27% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update edc000a...86c123b. Read the comment docs.

thazhemadam commented 2 years ago

Thank you for making this PR @simonschoelly!