Chemellia / ChemistryFeaturization.jl

Interface package for featurizing atomic structures
https://chemistryfeaturization.chemellia.org/dev/
MIT License
41 stars 14 forks source link

Update from json package from JSON to JSON3 #124

Closed thazhemadam closed 2 years ago

rkurchin commented 2 years ago

Looks like this needs a rebase off of the fixed Graphs thing?

codecov[bot] commented 2 years ago

Codecov Report

Merging #124 (191efec) into main (09cff80) will decrease coverage by 1.23%. The diff coverage is 88.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
- Coverage   87.42%   86.19%   -1.24%     
==========================================
  Files          17       18       +1     
  Lines         493      507      +14     
==========================================
+ Hits          431      437       +6     
- Misses         62       70       +8     
Impacted Files Coverage Δ
src/ChemistryFeaturization.jl 80.00% <0.00%> (-20.00%) :arrow_down:
src/data.jl 0.00% <ø> (ø)
src/features/speciesfeature.jl 72.72% <73.68%> (+72.72%) :arrow_up:
src/atoms/atomgraph.jl 75.94% <81.81%> (-1.33%) :arrow_down:
src/features/orbitalfeature.jl 78.12% <88.88%> (-2.53%) :arrow_down:
src/codecs/onehotonecold.jl 96.00% <95.00%> (-4.00%) :arrow_down:
src/codecs/directcodec.jl 100.00% <100.00%> (ø)
src/codecs/simplecodec.jl 100.00% <100.00%> (ø)
src/features/elementfeature.jl 80.95% <100.00%> (-7.29%) :arrow_down:
src/features/features.jl 100.00% <100.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update edc000a...191efec. Read the comment docs.