Closed thazhemadam closed 2 years ago
Merging #126 (8b602d5) into main (0dd3b61) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## main #126 +/- ##
=======================================
Coverage 86.19% 86.19%
=======================================
Files 18 18
Lines 507 507
=======================================
Hits 437 437
Misses 70 70
Impacted Files | Coverage Δ | |
---|---|---|
src/utils/graph_building.jl | 98.36% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 0dd3b61...8b602d5. Read the comment docs.
Okay, should we just merge this? I think at least fewer of them are failing than before... 🙄 though I'm sort of inclined to just ditch doctests given how finicky they are
I think we should merge this for now. We can get back to the doctests later, but this also fixes up the problem of the docs not building at all IIRC. Either way, this has been around for a long time now and should probably be merged right away.
doesn't seem to work anymore, as it returns a
missing
instead of anAtomGraph
.The following error gets thrown -