Chemellia / ChemistryFeaturization.jl

Interface package for featurizing atomic structures
https://chemistryfeaturization.chemellia.org/dev/
MIT License
41 stars 14 forks source link

more features, sources, allow user to add features #5

Closed rkurchin closed 3 years ago

rkurchin commented 4 years ago
adinhobl commented 3 years ago

When this says "load sources", are you referring to the deepchem.molnet.load_*source*(featurizers, splitters) for each of the molnet datasources? There are also other options methods for loading from disks, dataframes, and arrays

rkurchin commented 3 years ago

I'm not familiar enough with molnet to know exactly what you're talking about there, but what I'm referring to here is including more features (from other data sources) in the built-in data tables for the package. Currently it's mostly just atomic features from pymatgen and I think a few I pulled from matminer too.

adinhobl commented 3 years ago

I see. Deepchem contains methods to load the various MoleculeNet datasets and preprocess the data with splitters and featurizers.

rkurchin commented 3 years ago

Adding to this that it would be good also to build a way for a user to add in their own data source for atomic features that could hook into the automated vector-building functions. One could already in principle add user-sourced features but only by "manually" providing either feature matrices or at least vectors directly, so you couldn't use the functions that build features for you if only a list of feature names is provided.

rkurchin commented 3 years ago

This is covered by restructure PR and I neglected to link it, closing.