search

Chemellia / ChemistryFeaturization.jl

Interface package for featurizing atomic structures
https://chemistryfeaturization.chemellia.org/dev/
MIT License
41 stars 14 forks source link

Create `EncoderDecoder` and the default sub-type for `ElementFeatureDescriptor` #79

Closed thazhemadam closed 3 years ago

codecov-commenter commented 3 years ago

Codecov Report

Merging #79 (9085144) into main (5b379b6) will increase coverage by 0.17%. The diff coverage is 72.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
+ Coverage   76.48%   76.66%   +0.17%     
==========================================
  Files           8        8              
  Lines         319      330      +11     
==========================================
+ Hits          244      253       +9     
- Misses         75       77       +2
Impacted Files Coverage Δ
src/features/elementfeature.jl 80.55% <72.22%> (+0.55%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0cf4e56...9085144. Read the comment docs.

rkurchin commented 3 years ago

was this not based off of the latest main? Seems the reviewdog thing got messed up on ubuntu x86...nbd though, I assume that'll get fixed upon merge

rkurchin commented 3 years ago

Per Slack conversation, going to merge this and moving code to a separate module/adding specific tests/etc. can be done in subsequent PR's.