Chemellia / ChemistryFeaturization.jl

Interface package for featurizing atomic structures
https://chemistryfeaturization.chemellia.org/dev/
MIT License
41 stars 14 forks source link

add DummyFeaturization #87

Closed rkurchin closed 3 years ago

rkurchin commented 3 years ago

Resolves #85 .

codecov-commenter commented 3 years ago

Codecov Report

Merging #87 (4581d1c) into main (c5bde65) will increase coverage by 1.41%. The diff coverage is 76.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
+ Coverage   81.08%   82.50%   +1.41%     
==========================================
  Files          11       13       +2     
  Lines         312      320       +8     
==========================================
+ Hits          253      264      +11     
+ Misses         59       56       -3     
Impacted Files Coverage Δ
src/ChemistryFeaturization.jl 100.00% <ø> (+100.00%) :arrow_up:
src/atoms/atoms.jl 0.00% <0.00%> (ø)
src/features/elementfeature.jl 81.81% <ø> (-0.54%) :arrow_down:
src/features/speciesfeature.jl 0.00% <ø> (ø)
src/featurizations/graphnodefeaturization.jl 90.90% <ø> (-1.10%) :arrow_down:
src/features/features.jl 75.00% <50.00%> (+75.00%) :arrow_up:
src/featurizations/featurizations.jl 75.00% <66.66%> (+75.00%) :arrow_up:
src/atoms/atomgraph.jl 65.06% <85.71%> (+2.72%) :arrow_up:
src/featurizations/dummyfeaturization.jl 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c5bde65...4581d1c. Read the comment docs.

rkurchin commented 3 years ago

This approach is being abandoned, at least for now, and the docstring commits have been grabbed over in #90, so I'm going to close this.