search

Chemellia / ChemistryFeaturization.jl

Interface package for featurizing atomic structures
https://chemistryfeaturization.chemellia.org/dev/
MIT License
41 stars 14 forks source link

At/docs #90

Closed thazhemadam closed 3 years ago

thazhemadam commented 3 years ago

Add a few docstrings, and new section for Codecs

codecov-commenter commented 3 years ago

Codecov Report

Merging #90 (98fc669) into main (c5bde65) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 98fc669 differs from pull request most recent head eda6757. Consider uploading reports for the commit eda6757 to get more accurate results Impacted file tree graph

@@           Coverage Diff           @@
##             main      #90   +/-   ##
=======================================
  Coverage   81.08%   81.08%           
=======================================
  Files          11       11           
  Lines         312      312           
=======================================
  Hits          253      253           
  Misses         59       59
Impacted Files Coverage Δ
src/features/elementfeature.jl 82.35% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c5bde65...eda6757. Read the comment docs.

rkurchin commented 3 years ago

Can you grab commits 3c7032 through 4581d1c from #87 (excluding 04a1b78, I don't think we need to tag this) and add them to this since that's probably not going to get merged and those definitely fit under this header?

Also, for my own educational purposes, can you send me the lines of git that you run to do that? 🥺

rkurchin commented 3 years ago

(All the other stuff here looks great to me, thanks for adding those missing docstrings!)