search

Chemellia / ChemistryFeaturization.jl

Interface package for featurizing atomic structures
https://chemistryfeaturization.chemellia.org/dev/
MIT License
41 stars 14 forks source link

Fix atomgraph kwargs #97

Closed rkurchin closed 3 years ago

rkurchin commented 3 years ago

a semicolon got lost and then none of the keywords worked 😢 But now it's fixed 🎉

codecov-commenter commented 3 years ago

Codecov Report

Merging #97 (f88b55d) into main (99618bc) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #97   +/-   ##
=======================================
  Coverage   85.28%   85.28%           
=======================================
  Files          12       12           
  Lines         299      299           
=======================================
  Hits          255      255           
  Misses         44       44
Impacted Files Coverage Δ
src/atoms/atomgraph.jl 72.58% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 99618bc...f88b55d. Read the comment docs.

thazhemadam commented 3 years ago

aren't these changes the same as those proposed in #95?

rkurchin commented 3 years ago

facepalm oops yes On Jul 1, 2021, 7:23 PM -0400, Anant Thazhemadam @.***>, wrote:

aren't these changes the same as those proposed in #95? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or unsubscribe.

thazhemadam commented 3 years ago

haha no issues, #95 also removes a module redefinition, and does some minor refactoring a test too (+ docstring update) too. So I'll fix the merge conflicts, and merge that as well.