228 record to identifiers

Chemical-Curation / chemcurator_django

Backend services for chemical curation

https://api.chemreg.epa.gov

MIT License

1 stars 0 forks source link

228 record to identifiers #259

Closed michael-barbour closed 3 years ago

michael-barbour commented 3 years ago

closes #228

Pretty straight forward ticket. Added identifiers as a key and added to the included serializers.

The highest number I have now is probably 10-15. I could foresee cases where I could get over 100, but they would be very rare. Most common (~98% of the cases) is 1-4

This relationship could be heavy but with an expected upper bound of high teens, I think it's safe enough to set things up this way. If we happen to end up a lot of records with triple digit identifiers we may need to re-examine.

I added to the list fixture to add identifiers to record 21 for testing purposes.

debboutr commented 3 years ago

this looks good. I did run into an issue with the the self vs. related links for idenifiers. The self link works fine, but the related link throws an error. I would send this back, but I realize that there is a similar issue on the list relationship so it might be best to work those out together OR decide if we even need them both. I added a new folder that will show this in postman for the review.