Chemical-Curation / chemcurator_django

Backend services for chemical curation
https://api.chemreg.epa.gov
MIT License
1 stars 0 forks source link

249/250/251 sid cid rid as PK #272

Closed scaduto closed 3 years ago

scaduto commented 3 years ago

Closes #249 Closes #250 Closes #251

Handled the change of SID, CID and RID as PKs from tickets 249, 250 and 251 all under this ticket.

This was done concurrently to the massive migration squash that needed to be performed in order to successfully establish these fields as the new PKs for the Compound, Substance and Record tables.

Test revisions performed; Removed query_structure_type defaults previously performed in the Compound 001_initial migration. Added QST as an Ill-Defined factory field and revised related tests.

At the current state, these changes will break a large number of Vue Substance Page tests. Revisions will need to be performed on that side as well to properly map ID for the corresponding tables instead of their previous PKs.

UPDATE

The vue side has been modified under branch https://github.com/Chemical-Curation/chemcurator_vuejs/tree/249-Vue-CID-RID-SID Please run all e2e tests and confirm changes. All component references to CID and SID have been changed to ID and includes modified

UPDATE

Django docs have been updated to match the inclusion of the new PKs

scaduto commented 3 years ago

Please see above update in regards to changes to https://github.com/Chemical-Curation/chemcurator_vuejs/tree/249-Vue-CID-RID-SID to incorporate all Vue changes for 249/250/251