substance name regexp accepts "*" and "_"

Chemical-Curation / chemcurator_django

Backend services for chemical curation

https://api.chemreg.epa.gov

MIT License

1 stars 0 forks source link

substance name regexp accepts "*" and "_" #289

Closed cmgrulke closed 3 years ago

cmgrulke commented 3 years ago

As a curator I want additional characters to be acceptable in names So that I can properly name things when registering them

Acceptance Criteria: For both the display and preferred name

Accept an asterisk "*"
Accept an underscore "_"

Test:

hausman-gdit commented 3 years ago

Changed to raw to remove escape characters. Took a quick inexpert look at tests and I don't think I need to modify them. Can I get some handholding on commit/PR/'swimlane' changes/migrations stuff? Thanks! preferred_name_regex = r"^[a-zA-Z0-9 =<>\-\*_':.,^%&\/{}[\]]{3,}$" display_name_regex = r"^[a-zA-Z0-9 =<>\-\*_':.,^%&\/{}[\]]{3,}$"

regex saved

hausman-gdit commented 3 years ago

I see some tests in #277, will attempt similar