Chemical-Curation / chemcurator_vuejs

Chemical registration and curation tool
https://chemreg.epa.gov
1 stars 0 forks source link

When selecting substance from sidebar, compound is nulled if appropriate #138

Closed cmgrulke closed 3 years ago

cmgrulke commented 3 years ago

As a user I want the compound to be nulled out if a substance is read into the substance page that has no compound So that I understand the substance better when browsing chemicals

Acceptance Criteria: When I select a DTXSID from the sidebar on the substance page or arrive on one from a search, the compound displayed always represents the substance that is loaded (including no structure if there is no structure

Test(s):

hausman-gdit commented 3 years ago

@cmgrulke I feel like this is the current behavior when using the sidebar tree. Especially now with the "Toggle Sidebar" button not being visible when a Substance is loaded (#119).

Steps to reproduce

note Although I did notice that if I open a Substance that has an associated Compound, then change the "Structure Type" to "None" I cannot save that removal of association between that Compound and Substance. The "Save Substance" button is greyed out and the 'Save Compound" button is also gone (when selecting "None").

Steps to recreate similar behavior I was able to get a 'dangling Compound' (like you are describing) while using the Search Bar.

? Would submitting/modifying tickets along these lines be more appropriate ?

cmgrulke commented 3 years ago

So anytime a substance is loaded into the substance page, I want the compound that is associated with the substance loaded in as well. I think of this as rather than a clear on navigating away, it needs to be an active load on navigation to the page (and I consider the clicking of a new substance in the sidebar or the search of a substance to be a navigation to a substance page).

jtumkur commented 3 years ago

Single search page has search link

Browse page has a