refactor substance page for compound saving in substance form

Chemical-Curation / chemcurator_vuejs

Chemical registration and curation tool

https://chemreg.epa.gov

1 stars 0 forks source link

refactor substance page for compound saving in substance form #149

Closed debboutr closed 3 years ago

debboutr commented 3 years ago

closes #122 closes #135 closes #147

[x] use URL routing so that a page refresh will load the substance if one is in the form http://localhost:8080/substance/DTXSID202000002 http://localhost:8080/substance?search=hydrogen%20peroxide
[x] add the compound to the substance form for saving
[x] substance link on the navbar clears out the page data
[x] PATCH update to QST can be done with Marvin
[x] "save substance" button enabled when appropriate
[x] compound saves to the substance on PATCH or POST

There is a whole lot going on in this branch, the PR in django #312 is needed for the tests to pass here.

hausman-gdit commented 3 years ago

It looks like clearing the marvin window was removed.

"Sample Substance 2" -> search "Solo Substance" , there is still an illdefined compound

149-ill-defined

michael-barbour commented 3 years ago

Looking at this PR, I'm not sure it achieves the ask for "A plan for refactoring and use of the store is outlined and documented". I was of the impression this ticket was supposed to facilitate team discussion and hopefully have us reach a more unified goal.

There was the offer to start a discussion last Thursday (01-07) that never actually got started, but I think that's a good idea and necessary for this ticket.

Some of my specific concerns are related to how code will have to be written using VueX as a data store and how non-reusable components become when we tie them to a specific piece of data within a VueX store.