left click (enable/disable) when geoclue fails make it crash

Chemrat / redshift-qt

redshift-gtk rewrite with C++/Qt

MIT License

29 stars 6 forks source link

left click (enable/disable) when geoclue fails make it crash #8

Open hmollercl opened 5 years ago

hmollercl commented 5 years ago

When geoclue fails (for example no internet) and icon is left-clicked, app crashes. The error could be better be handled so the app won't crash. redshift-gtk in same situation doesn't crash

hmollercl commented 5 years ago

Just found out that disabling when geocule fils to start crashes in gtk also, the thing is that in gtk the enabl/disable toggle is done in the context menu and not with left click over tray icon. I believe that that solution gives better control over geoclue failure. Also in rs-gtk when it crashes it gives the message that geoclue fails, that message comes from redshift itself.