search

Chemscribbler / aesopstables

3 stars 10 forks source link

pair_round can double assign a bye and a table to the same player #3

Closed AugustusCeasar closed 1 year ago

AugustusCeasar commented 1 year ago

This bug manifested itself in the Frankfurt Startup CO. Where one player would be assigned a bye for the round and also be given a table to play in. Consequently, another player would not appear in the round pairings at all, neither having a game to play nor being noted down as a bye.

Bug was recreated in a test tournament after the tournament (set up with 3 players with the proxy names: p1, p2, p3): bugtesting reproduction step 1 the error is not just visual, p3 ends round 1 with 4 points, 1 from the tie plus 3 from the bye. And p2 ends with 0 points. bugtesting result step 1

I did some preliminary digging into the issue and could find no reason for the error. When I run a mock of bye_setup in my local python setup, it gives me the right output. I will try to get the whole repo working to investigate further when i am back at my home setup.

Chemscribbler commented 1 year ago

I thought I had deployed a fix on the 17th, but was able to recreate some permutation of this, will take a look this evening.

Chemscribbler commented 1 year ago

I think I found the source and deployed a fix, please let me know if you still find issues - I was returning the wrong list, instead of active players minus the bye player, I was return all players minus the bye player