post_proc_mmx.asm: valgrind warnings

[GoogleCodeExporter]

via pp_filter_test.

$ valgrind ./test_libvpx 
--gtest_filter=MMX/Vp8PostProcessingFilterTest.FilterOutputCheck/0
...
[ RUN      ] MMX/Vp8PostProcessingFilterTest.FilterOutputCheck/0
==17851== Invalid read of size 8
==17851==    at 0x45A582: ??? (postproc_mmx.asm:87)
==17851==    by 0x4227D1: (anonymous 
namespace)::Vp8PostProcessingFilterTest_FilterOutputCheck_Test::TestBody() 
(pp_filter_test.cc:77)
==17851==    by 0x4CB91C: void 
testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, 
void>(testing::Test*, void (testing::Test::*)(), char const*) (gtest.cc:2090)
==17851==    by 0x4BFBC6: testing::Test::Run() (gtest.cc:2162)
==17851==    by 0x4BFE57: testing::TestInfo::Run() (gtest.cc:2338)
==17851==    by 0x4C001D: testing::TestCase::Run() (gtest.cc:2445)
==17851==    by 0x4C513F: testing::internal::UnitTestImpl::RunAllTests() 
(gtest.cc:4237)
==17851==    by 0x4CB49C: bool 
testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTe
stImpl, bool>(testing::internal::UnitTestImpl*, bool 
(testing::internal::UnitTestImpl::*)(), char const*) (gtest.cc:2090)
==17851==    by 0x4BE1D6: testing::UnitTest::Run() (gtest.cc:3874)
==17851==    by 0x42B198: main (test_libvpx.cc:44)
==17851==  Address 0x5c34ea4 is 324 bytes inside a block of size 328 alloc'd
==17851==    at 0x4C274A8: malloc (vg_replace_malloc.c:236)
==17851==    by 0x42C5CD: vpx_calloc (vpx_mem.c:132)
==17851==    by 0x42262F: (anonymous 
namespace)::Vp8PostProcessingFilterTest_FilterOutputCheck_Test::TestBody() 
(pp_filter_test.cc:52)
==17851==    by 0x4CB91C: void 
testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, 
void>(testing::Test*, void (testing::Test::*)(), char const*) (gtest.cc:2090)
==17851==    by 0x4BFBC6: testing::Test::Run() (gtest.cc:2162)
==17851==    by 0x4BFE57: testing::TestInfo::Run() (gtest.cc:2338)
==17851==    by 0x4C001D: testing::TestCase::Run() (gtest.cc:2445)
==17851==    by 0x4C513F: testing::internal::UnitTestImpl::RunAllTests() 
(gtest.cc:4237)
==17851==    by 0x4CB49C: bool 
testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTe
stImpl, bool>(testing::internal::UnitTestImpl*, bool 
(testing::internal::UnitTestImpl::*)(), char const*) (gtest.cc:2090)
==17851==    by 0x4BE1D6: testing::UnitTest::Run() (gtest.cc:3874)
==17851==    by 0x42B198: main (test_libvpx.cc:44)
==17851==

Original issue reported on code.google.com by jz...@google.com on 10 Jul 2012 at 11:32

[GoogleCodeExporter]

James did you write a test for this? 

Jim said that he fixed an old error, so he is prob the last one to touch this 
code. 

Original comment by albe...@google.com on 19 Jul 2012 at 10:15

• Changed state: Assigned
• Added labels: Component-libvpx, Mstone-11, Pri-0, ReleaseBlock-Stable, Tests

[GoogleCodeExporter]

Original comment by jimbankoski@google.com on 20 Jul 2012 at 12:09

[GoogleCodeExporter]

> James did you write a test for this? 

No this is running another tool across the tests. They're read errors as well 
so it might be hard to detect (vs. a write error) in a test.

Original comment by jz...@chromium.org on 20 Jul 2012 at 1:26

[GoogleCodeExporter]

Consider removing MMX and rely on SSE2 (Pentium4 or later).
Its difficult to find a CPU that doesn't have SSE2 to test on.  Use C code as a 
fallback.

Original comment by fbarch...@google.com on 19 Jan 2013 at 9:19

[GoogleCodeExporter]

Closing as outdated. Please re-file if appropriate.

Original comment by louquil...@google.com on 13 Aug 2013 at 11:21

• Changed state: WontFix