search

Chen-tao / webm

Automatically exported from code.google.com/p/webm
0 stars 0 forks source link

Use width based integer types in libwebm's mkvparser. #482

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
The mkvparser and mkvreader classes in libwebm use types long and long long. 

Instances of long and long long should be changed to use int32 and int64, 
respectively. The same applies to any instances of short, unsigned short, and 
unsigned char (int16, uint16, and uint8 respectively).

The reason for the change:
1) It is against the style guide we've agreed to use: 
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml
2) All code implementing IMkvReader causes lint errors due to use of type long.

Original issue reported on code.google.com by tomfine...@google.com on 11 Sep 2012 at 12:27

GoogleCodeExporter commented 9 years ago

Original comment by tomfine...@google.com on 11 Sep 2012 at 12:29