Some issues that just came up in review, and make it more difficult to review
code in libwebm than should be necessary:
- Single letter variable names (not loop counters and not used as index values)
- Ambiguous abbreviated words in variable names
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Variable_Names
- Non const refs passed around
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Reference_Argumen
ts
- Bracket placement, whitespace, indenting:
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Formatting
There are more. This is not an exhaustive list-- it's just the easy to find
examples from a review that's in progress.
Original issue reported on code.google.com by tomfine...@google.com on 9 Oct 2012 at 9:04
Original issue reported on code.google.com by
tomfine...@google.com
on 9 Oct 2012 at 9:04