Chen-tao / webm

Automatically exported from code.google.com/p/webm
0 stars 0 forks source link

vpx project doesn't compile on visual studio because of local __label__ is not supported #561

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
D:\BEAMING_NEW\projects\Networking\webm\libvpx\vp8\encoder\x86\quantize_sse2.c

my solution was like this because i saw how this was called with unique 
arguments:

#define SELECT_EOB(i, z) \
    do { \
        short boost = *zbin_boost_ptr; \
        int cmp = (x[z] < boost) | (y[z] == 0); \
        zbin_boost_ptr++; \
        if (cmp) \
        goto select_eob_end_##i##_##z; \
        qcoeff_ptr[z] = y[z]; \
        eob = i; \
        zbin_boost_ptr = b->zrun_zbin_boost; \
        select_eob_end_##i##_##z:; \
    } while (0)

ps: 
vsyasm is not yasm:
in readme there should be a note to put in 
C:\Program Files (x86)\Microsoft Visual Studio 11.0\VC\bin
the _win64/win32 native_ version of yasm (download and rename it) not the 
vsyasm.  if using the vsyasm the compilation outputs to directory specified by 
-o (not to object filename specified by -o as expected). witch results in an 
object by the name of the source file with obj extention.

Original issue reported on code.google.com by helpmep...@gmail.com on 16 Mar 2013 at 7:16

GoogleCodeExporter commented 8 years ago
Thanks for noticing this. If you'd like to submit a patch I can give you credit:
http://www.webmproject.org/code/contribute/submitting-patches/

Both i and z and independently unique. It's safe to use just one of them in the 
label name.

Original comment by johannkoenig@google.com on 21 Mar 2013 at 6:46

GoogleCodeExporter commented 8 years ago
Or send me your name/email and I can add it to this change:
https://gerrit.chromium.org/gerrit/46151

Original comment by johannkoenig@google.com on 21 Mar 2013 at 6:53

GoogleCodeExporter commented 8 years ago
Shimon Doodkin <helpmepro1@gmail.com>

Thanks for credit sounds fun :)!!!

Original comment by helpmep...@gmail.com on 22 Mar 2013 at 11:41

GoogleCodeExporter commented 8 years ago

Original comment by johannkoenig@google.com on 22 Mar 2013 at 5:12