mv_ref_idx problem

[GoogleCodeExporter]

Motion vectors outside the boundary can be referenced incidentally with broken 
code : see referenced discussion: 

https://groups.google.com/a/webmproject.org/forum/#!topic/webm-discuss/G8UTmsBhH
VE

Original issue reported on code.google.com by jimbankoski@google.com on 14 Aug 2013 at 4:56

[GoogleCodeExporter]

I've tried to duplicate this issue by creating a file that was 144x88 and then 
added the following code 

static INLINE int is_inside_2(int mi_col, int mi_row,
                              int cur_tile_mi_col_end,
                              int cur_tile_mi_row_end,
                              const MV *mv_ref) {
  // Check that the candidate is within the border.  We only need to check
  // the left side because all the positive right side ones are for blocks that
  // are large enough to support the + value they have within their border.
  return !(mi_row + mv_ref->row >= cur_tile_mi_row_end ||
           mi_col + mv_ref->col >= cur_tile_mi_col_end);
}

and then to vp9_find_mv_refs_idx inside the loop ( for (idx = 0; idx < 2; 
++idx) ), I added the following : 

    if (!is_inside_2(mi_col, mi_row, cm->cur_tile_mi_col_end,
                     cm->cur_tile_mi_row_end, mv_ref))
      printf("oops\n")

I'm not getting the oops in either encode or decode.    Do you have any other 
suggestions on how to get it to happen?    Should I try other resolutions? 

Thanks,

Jim

Original comment by jimbankoski@google.com on 14 Aug 2013 at 7:31

[GoogleCodeExporter]

See referenced patch:  

https://gerrit.chromium.org/gerrit/#/c/66357/

Original comment by jimbankoski@google.com on 20 Aug 2013 at 2:45

• Changed state: Started

[GoogleCodeExporter]

Original comment by jimbankoski@google.com on 20 Aug 2013 at 2:45

[GoogleCodeExporter]

Original comment by jimbankoski@google.com on 22 Aug 2013 at 1:25

• Changed state: Fixed