[bug]:添加Lottie动画问题 - Githubissues

ChenYilong / CYLTabBarController

[EN]It is an iOS UI module library for adding animation to iOS tabbar items and icons with Lottie, and adding a bigger center UITabBar Item. [CN]【中国特色 TabBar】一行代码实现 Lottie 动画TabBar，支持中间带+号的TabBar样式，自带红点角标，支持动态刷新。【iOS13 & Dark Mode & iPhone XS MAX supported】

MIT License

6.93k stars 1.46k forks source link

[bug]:添加Lottie动画问题 #529

Closed chaiqiwei closed 3 years ago

chaiqiwei commented 4 years ago

Base Info for this issue

Version：Latest Version as here
Language of App ：Objective-C/Swift
iOS System Version：iOS12
Prototype（是否是真机）：YES
Issue Type：Crash、Bug、Enhancement（希望能支持一个新需求）、Q-A

1. How to reproduce the problem.

点击当前选中的tabbarItem，动画还会播放

2. Please help me in this way.

我发现代码的判断逻辑有问题，

(BOOL)cyl_isSelected { BOOL isSelected = NO; NSUInteger tabBarSelectedIndex = self.cyl_tabBarController.selectedIndex; NSUInteger tabBarChildViewControllerIndex = self.cyl_tabBarChildViewControllerIndex; BOOL defaultSelected = self.selected; if ((tabBarSelectedIndex == tabBarChildViewControllerIndex) && defaultSelected && CYLPlusChildViewController.cyl_plusViewControllerEverAdded) { isSelected = YES; } return isSelected; } 这个方法里判断了CYLPlusChildViewController 但是我的项目并不需要中间的按钮，所以产生了此问题
3. Here is a Demo.

4. Here is my Debug log

ChenYilong commented 3 years ago

新版本v1.29.1中已修复

变更记录见: https://github.com/ChenYilong/CYLTabBarController/commit/062ad52c9cb0cee9fabbb9de6c3a0ad893713d86