ChenYilong / CYLTabBarController

[EN]It is an iOS UI module library for adding animation to iOS tabbar items and icons with Lottie, and adding a bigger center UITabBar Item. [CN]【中国特色 TabBar】一行代码实现 Lottie 动画TabBar,支持中间带+号的TabBar样式,自带红点角标,支持动态刷新。【iOS13 & Dark Mode & iPhone XS MAX supported】
MIT License
6.91k stars 1.45k forks source link

[bug]: CYLTabBarController's viewDidLayoutSubviews not call super #558

Closed iMinder closed 3 years ago

iMinder commented 3 years ago



Base Info for this issue

  1. Version:Latest Version as here
  2. Language of App :Objective-C/Swift
  3. iOS System Version:iOS14
  4. Prototype(是否是真机):YES
  5. Issue Type:Crash、Bug、Enhancement(希望能支持一个新需求)、Q-A

1. How to reproduce the problem.

在14的系统上,在一级页面present一个横屏页面时,导致页面卡死,发现是CYLTabBarController的viewDidLayoutSubviews里面有调用[self.tabBar layoutSubviews]导致了死循环,这里好奇为啥不调用[super viewDidLayoutSubviews], 苹果不是不建议直接调用layoutSubviews这个方法吗

2. Please help me in this way.

3. Here is a Demo.

4. Here is my Debug log


ChenYilong commented 3 years ago

新版本v1.29.1中已修复 

变更记录见: https://github.com/ChenYilong/CYLTabBarController/commit/062ad52c9cb0cee9fabbb9de6c3a0ad893713d86