Cheneth / coup-online

An online port of the card game 'Coup'
MIT License
95 stars 38 forks source link

Problem With Stealing #1

Open lucasmyers97 opened 4 years ago

lucasmyers97 commented 4 years ago

Twice while playing the game one player clicked "steal" and then clicked a different player, and all the other players were given the "Waiting for other players..." prompt. No other action could be performed and the games had to be quit.

Cheneth commented 4 years ago

Hi @lucasmyers97

I made some changes today regarding other small bugs, maybe that might have fixed it? I tried to reproduce this stealing bug locally, but I wasn't successful. Please let me know if you keep experiencing this. Were there any specific reproduction steps that you can remember or did it just happen from time to time?

Thanks for reporting the issue!

lucasmyers97 commented 4 years ago

Hi @Cheneth

I couldn't reproduce the bug either, playing different players in on my machine. I recall that we were able to steal on a few occasions when I was playing with other players. The only thing that I could think of which might be different is that the internet quality from some of the players was not perfect -- could there have been a command that didn't send properly from one of the players?

In any case, I plan to try playing again later. Is there any way I can save the internal state of the game or the move history so that I can send it your way if we run into this bug again? Or is there any way that we could restore a game to a previous state to try to circumvent the bug? Let me know.

Thanks for creating this online port, by the way! Definitely a fun quarantine activity.

Cheneth commented 4 years ago

Sorry, there is no way to save the internal state of the game at the moment. I suspect the issue might be that one of the clients had disconnected from the server in which case, the user is now notified.