search

Cheneth / coup-online

An online port of the card game 'Coup'
MIT License
95 stars 38 forks source link

Refactor some of the server code #11

Closed Brystephor closed 3 years ago

Brystephor commented 3 years ago

A lot of the code is copy and pasted with very small changes. This is refactoring some of that code into a more reusable format and consistent format. There is also a lot of 'magic strings' with no centralized location for making the strings easy to access. Adding constants where we can see what the types will be makes adding and extending changes much much easier. It'd be great to get this game to a state where we can add more roles from expansions.

Cheneth commented 3 years ago

I'll take a look at it soon, sorry just a little busy at the moment.

Brystephor commented 3 years ago

If you have a bug list, desired features list, or roadmap other than the issues tab for the repo then it'd be great to share that. I like the games web interface a lot. A few quality of life improvements on it would make it fantastic.

On Thu, Dec 10, 2020, 1:03 PM Ethan Chen notifications@github.com wrote:

I'll take a look at it soon, sorry just a little busy at the moment.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Cheneth/coup-online/pull/11#issuecomment-742797565, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHMW43A5Z56EAHQC6UFDCJ3SUEZSJANCNFSM4UP2KW4Q .

Cheneth commented 3 years ago

@Brystephor As of right now, there's no bug list other than the issues tab, but I do have a mental list of some potential features:

Did you have any ideas? You can email me at ejchen@uwaterloo.ca and we can chat about it!