search

Cheneth / coup-online

An online port of the card game 'Coup'
MIT License
108 stars 39 forks source link

Unable to rejoin game if any connection failure happens #61

Open lounsbrough opened 3 months ago

lounsbrough commented 3 months ago

When a player has any kind of network connectivity issue, that player is removed from the game and is unable to rejoin. Beyond that, if the leader ever disconnects, the entire game is over: https://github.com/Cheneth/coup-online/blob/64458b7e949fa1c1e77dcc4f8ea0e7c641494b5c/server/index.js#L125

Can we instead leave the game going, and allow users to connect back in? Perhaps each client can have a uuid in their browser and they could use that as an easy way to re-establish who they are in the existing game.

lounsbrough commented 3 months ago

@Cheneth - I saw some old, open PRs and didn't know if this is still maintained. I started a fork to fix this, but if you're no longer maintaining it then I won't bother.

Thanks!

lounsbrough commented 1 month ago

It appears this project is dead, I created a new version myself that has persistent game storage in Redis and resolves this issue.

https://coupgame.com/ https://github.com/lounsbrough/coup-online