search

ChengLiLab / nHi-C

4 stars 1 forks source link

Errors in the getNAD.R script and issues with the wf #1

Open bfosso opened 1 year ago

bfosso commented 1 year ago

Hi,

I'm trying to replicate your workflow but actually I've found some issue:

  1. In the Bedgraph files normalization it is not clear what this formula means: mat$V6 <- as.numeric(mat$V6)/sum(as.numeric(mat$V6)) * 100000000. Actually, bedgraphs have only 4 columns and not 6. I supposed: mat$V6 <- as.numeric(mat$V4)/sum(as.numeric(mat$V4)) * 100000000. Is that correctly?
  2. in the HMM calling NADs step I got this error: Error in getClass(Class, where = topenv(parent.frame())) : “TDist” is not a defined class. It seems you used the tileHMM package but I cannot find any import of this library in your code. Could you please better specify this step.
  3. Finally, even when the tileHMM library is installed and loaded the getNAD function stucks at the viterbiEMstep.

Thank you in advance

ChengLiLab commented 1 year ago

Sorry for the delay.

  1. The total column of the read count result depends on the hg19_1kb.bed file, if there are 3 column in this file, then the read count column is the 4th column. If there are 5 column in this file (including bin length and strand information), then the read count column is the 6th column.

  2. Yes, we used the tileHMM package. Sorry, we missed the code for importing the library and we have added it now. Thanks for your reminding !

  3. We have tested the code and it worked well with our datasets. We added a test dataset (mat.rds) for step5 HMM calling NADs. You can try to test with it.