search

ChenglongMa / SkinToneClassifier

An easy-to-use library for skin tone classification
https://chenglongma.com/SkinToneClassifier/
GNU General Public License v3.0
97 stars 13 forks source link

Images using the black and white flag without specifying bw #5

Closed wrightmk closed 1 year ago

wrightmk commented 1 year ago

If I run the command, stone -i ~/<path to image> --debug or explicitly give it the color option, stone -i ~/<path to image> color --debug, my image always appears in the bw folder and has the black and white color palette show up in debug mode. The only colored image I was able to get to work was the lena image from here http://www.lenna.org/. Any thoughts on what I'm doing wrong? Aside from that, great project!

ChenglongMa commented 1 year ago

Hi @wrightmk, thanks for your kind words!

It looks like the app has identified the image you want to process as a black and white image. If you want to specify the image type manully, you can do the following:

stone -i ~/<path to image> --debug -t color

Or

stone -i ~/<path to image> --debug --image_type color

Please let me know if it still doesn't work.

Thanks!

wrightmk commented 1 year ago

The above commands still seem to classify the image using the black-and-white method. Here's a screenshot of the command I ran and the output. I also was meaning to mention that the --debug flag will hang at 0%. It still opens up the results window and just hangs in the command line.

Screenshot 2023-08-28 at 2 30 40 PM
ChenglongMa commented 1 year ago

Hi @wrightmk, thanks for your feedback.

It's indeed a bug that the app cannot recognize the image_type option. I will fix it today.

The process bar hangs at 0% because the result window is still open. It will reach 100% if you close the window. PS: The result window will pop up when only one image is processed.

ChenglongMa commented 1 year ago

Hi @wrightmk. I've fixed the bug and released the new version. Please run 

pip install skin-tone-classifier --upgrade

to upgrade the library to the latest version.

Thanks again for your feedback.

wrightmk commented 1 year ago

Hi @ChenglongMa, thanks for addressing this! Works as intended now!

Hi @wrightmk, thanks for your feedback.

It's indeed a bug that the app cannot recognize the image_type option. I will fix it today.

The process bar hangs at 0% because the result window is still open. It will reach 100% if you close the window. PS: The result window will pop up when only one image is processed.

In Response to the process bar hanging, there is no ability to close the window. If you see my screenshot above, there's only window is only able to be minimized (no red dot).

ChenglongMa commented 1 year ago

Hi @wrightmk,

I'm glad it is working now :)

You can press any key to close the window whilst the window is in focus. Please note that if the command line is in focus then nothing happens. (Refer to https://stackoverflow.com/a/28322925/8860079)

ChenglongMa commented 1 year ago

Hi @wrightmk,

I will close this issue. Feel free to reopen it if there are further problems.

Thanks!