Cheos137 / ArmorpointsPlusplus

A light-weight mod overhauling vanilla ui components
https://modrinth.com/mod/armorpoints
MIT License
2 stars 2 forks source link

Incompatibility with betterhud [total-glitchout of appp] #13

Closed Haadty closed 2 years ago

Haadty commented 2 years ago

Description: I was modifying the hud to make it more like an RPG, and well I added Armor Points ++ / Health Stacking version v2.0.1 [1.12.2] to add the armor support I wanted from AttributeFix, so I combined the RPG-Hud so I can move more in the hud, and I've already removed the mod and everything and the problem is Armor Points ++ / Health Stacking, if the player is without armor the mod leaves the interface of game in case the textures are all white and buggy, but if you are with any armor the problem is solved as in the image, I also left a photo with the mods I was using to make the hud, but I'm sure it's the RPG-hud still

To Reproduce: 1-add Armor Points ++ / Health Stack version v2.0.1 [1.12.2] 2-and also put the RPG-Hud together and The Better Hud mod 3-normally ready the bug that happens, if it doesn't happen and just change the HUD type in RPG-hud options

Expected behavior: that the two modes merge seamlessly in the game's hud

Version: v2.0.1 [1.12.2]

Screenshots: 2021-10-14_21 26 51 2021-10-14_21 32 30

image

Haadty commented 2 years ago

Correction: I did more testing and the bug itself does not occur by the RPG-Hud but by the BetterHud mod 2021-10-14_21 53 20

Haadty commented 2 years ago

and I also tested it without the mod, and yes the bug only occurs when you have Armor Points ++ / Health Stack version v2.0.1 [1.12.2] along with the 3 2021-10-14_22 04 41

Cheos137 commented 2 years ago

Sounds like a pretty annoying incompatibility to me, though i have an idea of what went wrong here. - probably not fully Appp's fault (only partially, if any). Gonna give this quite a high priority and look for what i can do on my end to improve/fix this behaviour.

Cheos137 commented 2 years ago

Just looked into betterhud - Appp and betterhud are mutually incompatible by design. BUT: like i'm planning to do for fancyhud, i'm gonna add full support for betterhud. (Appp v2+ for 1.8, 1.12, 1.16 has a small internal design flaw which i just noticed now - it's fixed in 1.17 due to a new forge api which prevents just that flaw by design. -- could fix this flaw, but this wouldn't fix compat with betterhud/fancyhud, so my only option left is to add support for them which i'll happily do - probably soon™)

Haadty commented 2 years ago

an interesting one, well i hope i have helped with something with the mod, i like it a lot and its compact that it gives to the hud, the one thing, and an idea I actually wanted to talk about, as the normal armor bar changes according to the amount of armor, it could also have in toughness armor, it would be really cool and would make the mod more complete since it has armor as mod times that exceed 20 armor toughness

Cheos137 commented 2 years ago

An individual toughness bar will be included (via config option) in the patch of #11. Probably will be in v2.2.0 (which will probably be the next version, including compat for betterhud)

Haadty commented 2 years ago

one so it will be in the same mode as the armor bar, I thought the idea would be the two bars all together, since this is a very big charm of the mod, the two being together, but having this option is very good too, good luck hey, I hope I helped

Cheos137 commented 2 years ago

That's actually quite a good idea to have the small toughness icons colir scaling, too - thanks for the idea and your support :D

Cheos137 commented 2 years ago

I'll just have to find a way to make the config not too complex

Haadty commented 2 years ago

I have an idea, there in the photo there is a bar that you move and change the names, this could also be used in this toughness bar, it would have 3 modes, the first would be off, the second the compact mode, the third the separate one, and also as possibly the toughness bar can have a color change depending on how much you have, it would be interesting a way to see how much of it you have in equal numbers and done in the armor bar, it can even be together with the armor or separate when the option is set to separate the two bars

image

Haadty commented 2 years ago

I don't know if it would be possible to make a bar picker, but I remember seeing this in some mods so here's the idea, but I must have imagined it but I do remember seeing something like that around

Cheos137 commented 2 years ago

A bar picker ain't that hard to make... no problems on my end here :D I just got another idea... there has to be a way to use the config ui in 1.16+ (although i don't know how to do it - 1.12 did it automagically)... maybe i'll look into that sometime soon™, too...

Haadty commented 2 years ago

in 1.16 has changed a lot in the programming of forge and its methods, but maybe it's something of changes or something similar

Haadty commented 2 years ago

I thought a lot maybe a slider selector will make things cleaner in the options, since you won't need 2 things to choose to activate and separate, just two, maybe you can change something a lot too, like adding the activate option to custom armor bar along with the option to turn the text on the side as the third option in the selector

Haadty commented 2 years ago

Well, I think it's a good idea to use the selector using bars so everything would be more compact and cleaner

Cheos137 commented 2 years ago

forge sadly uses sliders only for number ranges :/ but buttons would work... (which should be used for enums - the way i'd implement such restricted options...)

Haadty commented 2 years ago

:( so I was really imagining things, more and more sad it would help many mods to have this option, at least so much in mods to configure it would be all in one bar

Haadty commented 2 years ago

another idea then would be to divide the configurations into category like you did, but now like one for armors both and one for heart, I think the easiest way to make it more organized is to divide more

Cheos137 commented 2 years ago

well... sliders could be possible in 1.16+ - but as i said... have to look into that, still

Haadty commented 2 years ago

I understand it now, my english had confused me and it's still a little bad, good luck in the mod I hope it improves a lot

Cheos137 commented 2 years ago

thank you :D

Cheos137 commented 2 years ago

Probably will be in v2.2.0

Next update will be 3.0.0 - i changed a couple things in the config for 1.12, making it fully incompatible with previous version (is now ways better in the gui, though) Meaning: I'll make some changes to the core structures right away (instead of waiting until 2.2.0 is done)

Haadty commented 2 years ago

nice, so you should have less incompatibility in fashion and maybe bugs you don't even know about, fix yourself

Haadty commented 2 years ago

I was looking here, have you ever thought about doing something for the hunger bar? at least add her that number on the side that counts or something, she's abandoned kkkkk

Cheos137 commented 2 years ago

A number next to the hunger bar is something i could do... but i'd do nothing more than that, because otherwise it would render AppleSkin useless (and i don't want that as i kinda fancy that mod)

Haadty commented 2 years ago

it's true that mod is very good, but it's just an idea kkk but maybe it's nice to have a number on the side that you activate optional to make the mod more complete

Haadty commented 2 years ago

I was tinkering with the colors of the armor a little, I thought red as a second was very strange and bad, in my head it should be there for the last ones, and the last one should be something unbreakable like bedrock, I thought that made it more interesting, and so did I tried to reduce to the maximum the very strong colors that I thought were spoiling some things a little, I thought it was more decent like that in my opinion, but to tell you for real the red as the second palette of the bar was strange icons

Haadty commented 2 years ago

more and just my taste no biggie

Cheos137 commented 2 years ago

Red's tthe second, so that starting with red, the colors of the armor & health bar are identical - it would be an idea to move red all the way to the end, though... Also, the other day i was thinking about making different texture schemes (simple, vanilla-like, modern, etc.)... would fit right in there, right?

Haadty commented 2 years ago

yes, but i think the idea of ​​you can change the texture by yourself is very good, if you don't like it you can tweak the texture of the mod and change it to whatever you want

Haadty commented 2 years ago

another idea would also be to make the system in case the hud of the bar is changed according to a user's color school, like using hex colors like this, the person chooses the color it applies to the bar and changes it to the desired color for each level by the user, it's a good idea but it should work the handle as you would have to change the entire code

Haadty commented 2 years ago

Also, it would be great to add a shadow below the numbers on the hud, because there are times when you can't see the number, like you're in the snow and you can't see anything if it's all white, so an umbrella underneath is the same what's in vanila would be interesting

Cheos137 commented 2 years ago

the appp glitches when used together with betterhud are resolved in 3.0.0 (1.12 alpha build yet to release) all remaining issues are not appp's but betterhuds fault