Cheos137 / ArmorpointsPlusplus

A light-weight mod overhauling vanilla ui components
https://modrinth.com/mod/armorpoints
MIT License
2 stars 2 forks source link

[Bug]: Turning "showToughnessValue" to false doesn't actually remove the text value next to the Toughness Bar. #24

Closed Gbergz closed 2 years ago

Gbergz commented 2 years ago

Is there an existing issue for this?

Description

Currently have this: (useToughnessBar is enabled!)

    # Show toughness value text next to toughness bar
    # Available: true, false [default: true]
    showToughnessValue = false

but the text next to toughness bar is still being rendered despite being disabled. disabling this option for health works, but not for toughness.

Version

Other (this list is not up to date - again...)

Version

forge-1.18.2-3.0.0

To Reproduce

  1. Set useToughnessBar from false to true
  2. Turn showToughnessValue from true to false
  3. Start game, go into a world.
  4. Put on some armor with toughness values.
  5. Text still being rendered. Profit.

Expexted Behavior

That the text is disabled next to the Toughness bar.

Additional Context

Edit: Oh while I'm here, would it be possible to add the colored health to ingame tab? Currently use this on servers to display everybody's total health on TAB. (/scoreboard objectives add h health -- then use -- /scoreboard objectives setdisplay list h)

Screenshots

image

Relevant Log / Crash-Report Output

Nothing to show in logs.
Cheos137 commented 2 years ago

fixed in 3.0.1 (98bf1a5)

also i've opened a feature request for the scoreboard thingy

Gbergz commented 2 years ago

Awesome thanks for the fix. And thanks for bringing the feature request forwards. :)