Cheos137 / ArmorpointsPlusplus

A light-weight mod overhauling vanilla ui components
https://modrinth.com/mod/armorpoints
MIT License
2 stars 2 forks source link

[Bug]: The chat and pause menu is moved to the side in 1.16.5 #53

Closed ItsVenty closed 1 year ago

ItsVenty commented 1 year ago

Is there an existing issue for this?

Description

I was testing mods to use for the game when I came across a bug. Whenever I load this mod in a world the screen is cut to the side a little along with the pause menu. Will there be a fix for this anytime soon?

Version

3.0.x for Minecraft Forge 1.16.5

Version

No response

To Reproduce

  1. Download Minecraft 1.16.5 along with this mod and the JourneyMap mod
  2. Run the game with the mod
  3. Make a world and enter it
  4. Open the pause menu (optional)

Expexted Behavior

No response

Additional Context

No response

Screenshots

No response

Relevant Log / Crash-Report Output

No response

Cheos137 commented 1 year ago

Doesn't normally happen (got fixed previously) in latest (3.0.6) and will never happen with solely ap++ installed.

Any other mods you're using that might influence this outcome? Otherwise i will close this as not-a-bug.

ItsVenty commented 1 year ago

Oof mb sorry, the bug happens whenever I pair the mod with the JourneyMap mod

Cheos137 commented 1 year ago

then the only thing i can think of is this being a duplicate of #27. If you are using 3.0.6, do you mind testing the latest 3.1.0 alpha build (available on my discord)?

ItsVenty commented 1 year ago

Sure I'd be down edit: I just joined the server and tested the Alpha build, it crashed :/

Cheos137 commented 1 year ago

can you send me the crash report? :sweat_smile:

ItsVenty commented 1 year ago

crash-2022-12-22_16.30.41-client.txt

Cheos137 commented 1 year ago

Okay, the crash is unrelated to the initial issue - i don't know whether i'll have time to fix it today though

ItsVenty commented 1 year ago

It's alright take your time :D I'll be here if you need anymore info

Cheos137 commented 1 year ago

Posted a new build (3.1.0-alpha4-exp1) on the discord aiming to fix both issues you're encountering. (Yes, i did manage to squeeze like 20mins in to do this)

ItsVenty commented 1 year ago

It works now, but the screen is still sideways

edit: Yes I know there are other mods but I've tested all of them and they work fine except with the JourneyMap mod) 2022-12-22_22 48 14

Cheos137 commented 1 year ago

what do you mean by 'your screen being sideways'?

ItsVenty commented 1 year ago

Apologies for the inconvenience and delay as it was nighttime for me at that point. What I meant by "sideways" is that the screen is "a few ways to a side", which I was referring to the issue of the chat and the pause menu being a bit to the side (better screenshots below).

(you can kinda see it on the top left of my image from earlier, but I can understand if that bought up insufficient information) (oh and F3 works perfectly fine btw) 2022-12-23_12 00 37 2022-12-23_12 00 31

Cheos137 commented 1 year ago

I read some of JourneyMap's source code and i think I've found the problem now - published another experimental build on discord (3.1.0-alpha5-exp2)

ItsVenty commented 1 year ago

Yeah, hate to break it to you but, it crashed again 🤣 crash-2022-12-29_14.01.16-client.txt

Cheos137 commented 1 year ago

Well, crashes are usually easier to fix than weird behavior... with the exception of most crashes caused by matrix stack shenanigans when working with other mods... but i think it's nothing i can't fix :)

EDIT: found the cause, though i'm confused as to why it didn't crash at a different place where exactly the same thing goes wrong

Cheos137 commented 1 year ago

posted exp3 on discord

ItsVenty commented 1 year ago

Alright, I've tested it and it works! I didn't get what you mean by your first comment (like... what place exactly?) But even so, I'm glad that you could fix it in such a short notice. But I have one tiny issue to report-

Are the armor and hp values, supposed to overlap like this? (i mean im okay with it, but whenever I take damage, it blocks the the view of the armor value) 2022-12-30_11 39 24

Cheos137 commented 1 year ago

I didn't get what you mean by your first comment (like... what place exactly?)

just me ranting, nothing to worry about :)

Are the armor and hp values, supposed to overlap like this? (i mean im okay with it, but whenever I take damage, it blocks the the view of the armor value)

no, they are not supposed to overlap... and looking at the code i don't know why they overlap for you but you can manually configure their position using the config (set textconfig.enableHealthValueConfig = true and reposition the text using textconfig.healthValueX and textconfig.healthValueY) (correct values for x and y will probably be at around x=120 and y=39 for you)

also, i will close this issue as the actual issue (journeymap incompatibility) has been fixed