search

Cherry / 3D2D-Textscreens

3D2D Textscreens Garry's Mod Workshop Addon
https://jross.me/3d2d-textscreens/
MIT License
27 stars 20 forks source link

Bug with Fading Door tool #51

Closed FirecodePublic closed 5 years ago

FirecodePublic commented 5 years ago

Hi! Youtuber Urbanichka founded bug and use him to destroy servers.

The bug is: If you have Fading Door TOOL You can select all functions in it like activate immediately, etc and click to Text screen and Owner text is removed and you can't delete THIS TEXT this is very bad, you only need to clear the card, but the players are playing. I hope you understand I used google translator.

Youtuber - Urbanichka

Cherry commented 5 years ago

Thanks for the bug report, I think I understand. I'll investigate as soon as I can.

Cherry commented 5 years ago

I've tried to replicate the issue with https://steamcommunity.com/sharedfiles/filedetails/?id=115753588, but can not do so on a server. There's some weird behaviour when running singleplayer, but that's not a concern.

The hook I add prevents any tool other than the remover and textscreen from working on textscreen entities, so there's no real possible way for the fading door tool to activate on a textscreen entity, unless there's another addon overriding this behaviour. It's possible that Fading Doors has its own hook that's overriding mine, but there's not a huge amount I can do about that. https://steamcommunity.com/workshop/filedetails/discussion/115753588/358416640400587447/ talks about a similar issue.

FirecodePublic commented 5 years ago

Sorry I did not understand, have you fixed the bug or not?) I just don't speak English well

FirecodePublic commented 5 years ago

Reopen check up comment

Cherry commented 5 years ago

No, I'm unable to replicate the issue, sorry. Let me know if I can clarify anything from my previous message.

mcNuggets1 commented 5 years ago

Give us a video. I'm still receiving e-mails from an email account I don't have github access to. I have to read through this stuff, all the time.

If you cant speak english, then give us a VIDEO. Visualization of the issue, ya know.

FirecodePublic commented 5 years ago

https://www.youtube.com/watch?v=gLg4q3sd4X0

Cherry commented 5 years ago

Is there a specific timestamp in this video where I can see the issue? That looks to be on a server with a lot of other addons too. I really need a vanilla setup and specific steps to replicate the issue. See my comment at https://github.com/Cherry/3D2D-Textscreens/issues/51#issuecomment-459189857 for further details.

Cherry commented 5 years ago

I'm going to close this. If you can provide more information @FirecodePublic I'd be happy to take another look.