Cherry / 3D2D-Textscreens

3D2D Textscreens Garry's Mod Workshop Addon
https://jross.me/3d2d-textscreens/
MIT License
27 stars 20 forks source link

Textscreens are invisible #7

Closed Awesome123123 closed 9 years ago

Awesome123123 commented 9 years ago

Hello, I am not sure if you check your comments for the text screens but I decided to write it here. All textscreens that are placed down are invisible. It would be nice if you made a patch for it.

Thanks,

Awesomenessman

Cherry commented 9 years ago

Hello,

Thanks for the report! I'm very aware of the current issues but am out of the country at this time. I will take a look as soon as I get a spare moment.

Dellkan commented 9 years ago

Hey guys.

Cherry/James has asked me to look into this problem in his absence.

Now, first things first, I can't actually reproduce the issue. Taken today (It's a screenshot taken today)

As such, I'll need your guys help to reproduce, and understand the issue to fix it.

I'll need all the following pieces of information. Please fill out a reply:

Finally, if possible, post a screenshot of what the textscreen (or lack thereof) looks like.

I'd also appreciate if someone could post a full console log from joining a server to spawning a text-screen. Use pastebin for this.

metallicgloss commented 9 years ago
  1. There is no text at all, it is invisible.
  2. The invisible box is there and can be found by hovering over it with C held.
  3. No errors what so ever.
  4. No.
  5. Other addons have stopped working. Mining System from scriptfodder not displaying them.
  6. I have tried running it with no addons and in sandbox and it still doesn't show the text.
  7. "mat_dxlevel" = "95" ( def. "0" )
  8. Yes, and nothing had to be re-obtained. No-one on my server can see it either.
  9. I have nothing there

I have also tested it in a dedicated DarkRP server hosted with SerinityServers and they still do not show up in sandbox or when the gamemode DarkRP is running. All of the other other addons that use text screens dont work there either. I hope this helps to help to get it fixed.

Dellkan commented 9 years ago

It's a good start, thanks.

Can you give me the server ip for one of these? I'd like to visit, see if they'll be broken for me too.

The fact that other addons has become broken for you leads me to believe that gmod itself either broke something, or messed up something. Likely, we'll find our answer in messing with either graphic settings, launch options, or some other gmod setting. Whatever fixes it for you, will likely fix it for all your broken addons (including textscreens). It also means that it is unlikely that anything can be done from textscreen's end. (I'll keep looking though, these are just initial guesses)

All that said, the comments everywhere indicates we're dealing with many different issues, so please, keep those replies coming.

metallicgloss commented 9 years ago

Our DarkRP server that it is currently on is: 185.38.148.159:27165 and yes, since the update, your text screens and others arent working.

FredKing27 commented 9 years ago
  1. No textscreens appearing
  2. Box around the invisible textscreen when you press c or hit it with a phys gun
  3. No errors
  4. I don't use default printers so I wouldn't know however, my current printer plugin is working and it can be found here http://steamcommunity.com/sharedfiles/filedetails/?id=176802773
  5. Enhanced Meth Lab from scriptfodder and drugs mod. Meth lab has no info on the meth and drugs mod has no on screen effects
  6. Yes still no text
  7. mat_dxlevel = 90
  8. Yes It had to get 2 files however, after it was done nothing changed same problems.
  9. N/A

Gl Dellkan I rly hope yall can fix this

Dellkan commented 9 years ago

Thank you for the report. Looking at your printer was especially illuminating.

Testing with @metallicgloss revealed some result.

I joined @metallicgloss server, and found that I too couldn't see the textscreen. After a little investigation, I found that my clientside never received the textscreen data (what the text should be, font size, font color, alpha, etc). Updating this data manually from the clientside fixed the problem.

Textscreens uses a large amount of NetworkedVariables (SetNWInt, and so forth). Apparently, the last gmod update introduced a smaller limit (32, down from 64) variables that could be active at one time on an entity. Simple guesswork, but it would appear that when that limit is reached, no data it sent or synched at all.

@FredKing27's printer works because it's using an entirely different method of communicating.

On my own test server, both I, and @metallicgloss could see both our own, and each other's textscreens just fine.

So where does that leave us?

Don't think this is your problem?

That could very well be. From reading the comments, it looks like we're wrestling with multiple issues. So please, post more replies following the format above.

FredKing27 commented 9 years ago

Maybe garry should undo the change it seems a bit silly of them to break a lot of addons just to change a small thing for as i see it with no reason to do so.

metallicgloss commented 9 years ago

I would agree, but how would one contact him?

FredKing27 commented 9 years ago

idk maybe leave feedback for valve or something

Dellkan commented 9 years ago

Reading over the changelog again (http://www.garrysmod.com/updates/), I might have misunderstood (NetworkVar got the reduced limit from 64 down to 32, not NWVars as I initially thought), which means that NWVars has a bug that prevents them from working, not a limit they've reached. There's 4-5 different ways of communicating in Garry's mod, and they all have similar names, and switch (frequently) between which is recommended for usage, and which is obsolete/deprecated. It's a somewhat frustrating terrain to cover.

Either way, I've finished rewriting a fix, which seems to work, but I won't know for sure until I have had testers confirm. See https://github.com/Dellkan/3D2D-TextScreens and give me some feedback.

Please bear in mind that the above fix has incompatible changes to how the screens are persisted, and as such, you may get errors related to loading old, and/or they may simply not load (you may have to set up persisted textscreens all over again)

metallicgloss commented 9 years ago

I have fixed my server, if you update you server if you have it hosted. It fixes all issues.

yahell1 commented 9 years ago

Does the textscreen have any text at all?: No Just a sort invisible square where it should be Can you see a box/prop where the textscreens were supposed to be?: Yes Have there been any errors at all?: No Does printers in DarkRP have their text?: Yes (But im using https://scriptfodder.com/scripts/view/768) Do you have any other mod with text that stopped working, or is still working?: Yes (The Text on the Drug Printers seems to be frozen (https://scriptfodder.com/scripts/view/989) Have you tried running textscreens in sandbox gamemode with absolutely no other addon?: No Type mat_dxlevel in console. What does it output?: "mat_dxlevel" = "95" ( def. "0" ) Have you tried verifying integrity of game cache?: Can't its being hosted by a provider Check "Set launch options" in steam library on gmod. If you have any options in there, copy paste them here: Can't its hosted online

Proof

As i was spawning a textscreen i noticed this Requesting texture value from var "$basetexture" which is not a texture value (material: gpurt) Requesting texture value from var "$basetexture" which is not a texture value (material: gpurt)

This was in red

But then i tried again and this did not appear ^

yahell1 commented 9 years ago

I just updated and it fixed the issue.. thanks alot <3

Swagrenade commented 9 years ago

It works fine. All I did was run the steam updater and updated to beta version of DarkRP.

Cherry commented 9 years ago

Huge thanks to @Dellkan for taking care of this whilst I was gone.

It appears that the NWVar changes have been reverted, which inadvertently fixed the issues experienced, however I have gone ahead and merged the changes anyway, as it produces much cleaner code, and fixes a couple of outstanding issues too.

Unfortunately the change in network libraries and data storage in the recent version has resulted in all perma text screens having to be recreated. This shouldn't happen again in future, and my apologies for any inconvenience.

Feel free to open another issue if you guys run into anything else!