CheshireCaat / bas-remote-node

NodeJS library, which allows you to automate Google Chrome browser.
MIT License
28 stars 7 forks source link

Error while trying to delete old script folder. #5

Closed bablosoft closed 4 years ago

bablosoft commented 4 years ago

Steps to reproduce:

1) Create new BAS script and upload it to server. 2) Run it with following code:

const scriptClient = new BasRemoteClient({ scriptName: 'YourScriptName' });
await scriptClient.start();
await scriptClient.close();

3) Make any change and upload script on server. 4) Run it again with same code.

Actual result:

You will get error

directory not empty, rmdir 'd:\dev\BASRemoteControl\node\data\run\TestRemoteControl\3afb1'

CheshireCaat commented 4 years ago

I tried to reproduce this problem, everything works fine for me, but I found information that recursive rmdir cannot be used in versions of NodeJS lower than 12 (i use v12.13.0). I fix it soon.

bablosoft commented 4 years ago

Yes, that is probably because old node version, but please fix anyway.

CheshireCaat commented 4 years ago

Please, try a new version

bablosoft commented 4 years ago

Thanks, it works.