search

ChessCom / Chess-Game

Based on Pear Games_Chess - represents a chess game as a php object
Other
42 stars 20 forks source link

PHP 7.2 support #34

Closed lackovic10 closed 5 years ago

lackovic10 commented 5 years ago
marcosdsanchez commented 5 years ago

Thanks! Let's use this ticket to provide support for php 7.2 .

Can you please disallow failures in travis? https://github.com/ChessCom/Chess-Game/blob/develop/.travis.yml#L8-L9 .

lackovic10 commented 5 years ago

@marcosdsanchez i've pushed https://github.com/ChessCom/Chess-Game/pull/34/commits/3b485802aa3ac6bb5bbf12cd3f49b9941256cb90, let me know if this is what you've expected for the travis configuration

lackovic10 commented 5 years ago

@marcosdsanchez i think the test is not redundant, it's testing the _validMove() method which i think is fine, but i removed the test anyway.