search

ChessCom / browser-extension

Customize your Chess.com experience
Other
48 stars 15 forks source link

Add link to logo and username in Header component and add hover state #34

Closed rish closed 8 years ago

rish commented 8 years ago

Adds a Link component to wrap the logo in the header and also the username.

The extra CSS file is just to handle hover state. We would probably add more to this further down the line if we cant linked stuff to be styled differently perhaps.

jeffreydunaway commented 8 years ago

How responsive is the CSS file? Also, does the extra CSS file reduce the optimization of the overall performance?

martynchamberlin commented 8 years ago

The browser extension's max width is too narrow for responsiveness to be a concern. We're at 300 pixels max width and this extension is for desktop only anyway.

Additional CSS documents to a project should never affect performance from an I/O standpoint, because they all get bundled into a single unit. The only additional overhead from a production standpoint will be the actual amount of CSS that's added, which in this PR is exceedingly minimal.