search

ChessCom / browser-extension

Customize your Chess.com experience
Other
48 stars 15 forks source link

Links now open in new tab #90

Closed ManBearPigg closed 7 years ago

ManBearPigg commented 7 years ago

This is a fresh new pull request providing the functionality that was discussed in the former pull request "Links open in new tab". Links will now open in a new tab instead of hijacking the current tab.

emilgoldsmith commented 7 years ago

Yep this is all good now! Thanks, it looks so nice and clean now :).

Only thing is CircleCI still refuses to build. @martynchamberlin I'm assuming you have access to the CircleCI account and can handle this somehow? I'm assuming this has something to do with it being a fork and not an actual branch on the repo, I was googling a bit and there might be some options one can change, or at least I think I heard you can trigger a manual build or something?

martynchamberlin commented 7 years ago

Yep. Had to enable "Build forked pull requests" in CirlceCI. Just now made this change.

To trigger CircleCI for this pull request, we would need to update its commit history somehow. That's a little overkill though, so I'll just merge this.