ChessCom / browser-extension

Customize your Chess.com experience
Other
48 stars 15 forks source link

Modularize manifest files #94

Open emilgoldsmith opened 7 years ago

emilgoldsmith commented 7 years ago

This resolves #84.

Note: I have a temporary final commit that I will delete and force push before merging, it contains the built manifests with their old names in order to be able to review what the scripts output will look like in this PR while reviewing changes.

My biggest thoughts are actually on the actual manifests more than the code. Like for example:

Yeah so the above questions would be awesome to have some dialogue on. The one I'm most confused about is the content_security_policy. I assume there shouldn't really be a difference between Firefox and Chrome there right? So shouldn't we try and come up with a common CSP that we can apply to all of them? If we can't I have added support in the script to merge CSPs though, so if needed we can also do that, but currently I know that what I have done is not correct anyway.

emilgoldsmith commented 7 years ago

Yep, thanks for the review! I'll look into your comments and try and heuristic my way through finding a balance / correct manifest format.