Chessnut / moderator

An administrative add-on for Garry's Mod
GNU General Public License v2.0
19 stars 6 forks source link

Various issues. #1

Open aStonedPenguin opened 10 years ago

aStonedPenguin commented 10 years ago

Issues:

  1. Ranks aren't saving
  2. It prints chat "AdminName has toggled noclip for you" every time you toggle noclip
  3. Slight UI issue: http://gyazo.com/0029914d22a89f2871cf7327ad8ed504
  4. Bans list UI issue: http://gyazo.com/48f53f4054bbe28e15b1b1e6e6eb15e9
  5. Error when you try to set rank in game http://gyazo.com/188223e6160e88fdb567bd3977aae164

Suggestions:

  1. MySQL support asap
  2. Physgun player
jackwilsdon commented 10 years ago

Can you explain how issue 2 is a problem? Does the message appear when it shouldn't?

Edit: Issue 5 has been fixed by the commit bd0cbd1, looks like a spelling mistake.

aStonedPenguin commented 10 years ago

It prints chat when you toggle no-clip for yourself which I would assume is in assume or just something overlooked since most admin mods don't do that.

jackwilsdon commented 10 years ago

Does it print to everyone's or just your own?

Chessnut commented 10 years ago

Fixed #5, UI issues already known, #1 can't be replicated. #2 is intentional. What game mode are you using?

jackwilsdon commented 10 years ago

I struggled to replicate issue 1, and I tried fixing issue 2 by modifying line 109 of cl_menu.lua, it fixes it but modifies all other tabs (makes them too high from the bottom). It seems that the height of the DScrollPanel for the Statistics tab is too tall somehow. Not sure how to fix it.

jackwilsdon commented 10 years ago

I also cant reproduce issue 4, it looks fine for me. As @Chessnut said, maybe your gamemode is modifying something Derma uses?

aStonedPenguin commented 10 years ago

My derma theme overwrites the default gmod derma theme however it doesn't modify any functionally. Edit: Gamemode is DarkRP 2.4.x

jackwilsdon commented 10 years ago

It looks like somehow your derma theme is modifying the padding made by the list heading, so the list contents clip into it. Not sure how to fix that without messing with the theme.

Chessnut commented 10 years ago

This seems to be an issue with docking, I'll have to look into what is causing the UI errors.