ChestShop-authors / ChestShop-3

ChestShop - the chest & sign shop plugin for Minecraft Servers running Bukkit/Spigot/Paper
https://dev.bukkit.org/projects/chestshop
GNU Lesser General Public License v2.1
275 stars 176 forks source link

Non functional signs #498

Closed x1p closed 2 years ago

x1p commented 2 years ago

What is happening?

Chestshop won't allow to buy (or sell) from signs containing numbers and/or underscores.

Examples: EnchantedBook#1 Fortune 3 (via itemAliases.yml Enchanted Book#1: Fortune 3)

Normal materials work fine: Flame (via itemAliases.yml Enchanted Book#2: Flame)

It's probably related to https://github.com/ChestShop-authors/ChestShop-3/commit/5ec2ab61e5cefe4b9d69409576005d4a256eb531 Screenshot 2022-01-29 170955 Where as the old regex did match Screenshot 2022-01-29 171146 \w is the equivalent to [a-zA-Z0-9_]. Replacing this to \p{L} matches any kind of letter from any language. Hence missing the digits and _

What did you expect to happen?

Able to buy from all shops like previous builds

Plugin Version

ChestShop version 3.12.1-SNAPSHOT (build 341)

Plugin Config

Config ```yaml default! ```

Server Version

1.18.1

Server Log

Log ``` [15:29:55] [Server thread/INFO]: [ChestShop] Loading ChestShop v3.12.1-SNAPSHOT (build 341) [15:29:55] [Server thread/INFO]: [ChestShop] WorldGuard version 7.0.7-SNAPSHOT+2170-b59da59 loaded. ... [15:30:07] [Server thread/INFO]: [ChestShop] Enabling ChestShop v3.12.1-SNAPSHOT (build 341) [15:30:08] [Server thread/INFO]: [ChestShop] Found locales ar, it, es, el, hu, fr, pl, cs, pt_br, ja, sv, da, es_mx, sr, tr, nl, zh_tw, af, ko, no, vi, ro, he, ru, ca, zh, de, fi, en, uk [15:30:08] [Server thread/INFO]: [ChestShop] Updating Item Metadata database to data version 2865... [15:30:08] [Server thread/INFO]: [ChestShop] Finished updating database in 0.001s. 0 items out of 0 were updated! [15:30:08] [Server thread/INFO]: [ChestShop] Using CMIEconomy as the Economy provider now. [15:30:08] [Server thread/INFO]: [ChestShop] Vault loaded! [15:30:08] [Server thread/INFO]: [ChestShop] Using Paper's BlockDestroyEvent instead of the BlockPhysicsEvent! [15:30:08] [Server thread/INFO]: [ChestShop] Auto-updater is disabled. If you want the plugin to automatically download new releases then set 'TURN_OFF_UPDATES' to 'false' in your config.yml! ... [15:43:45] [Craft Scheduler Thread - 13 - ChestShop/INFO]: [ChestShop] PlayerExample created an Admin Shop - 33EnchantedBook#1 - B 1 - at [world] 21, 4, -7 ```

What other plugins are you running?

CMI, Chestshop

Agreements

Additional context

No response