ChestShop-authors / ChestShop-3

ChestShop - the chest & sign shop plugin for Minecraft Servers running Bukkit/Spigot/Paper
https://dev.bukkit.org/projects/chestshop
GNU Lesser General Public License v2.1
272 stars 178 forks source link

Fix NFE and some other possible issues #502

Closed Krakenied closed 2 years ago

Krakenied commented 2 years ago

Fixes #499

Phoenix616 commented 2 years ago

Thanks! Is this based on the logic how it worked before 99a609b4233bc0fab345190db859b9636dc15f6d or how were those changes made?

Phoenix616 commented 2 years ago

Ok I just cross-referenced it with the commit and it seems that there is an additional change in the PriceRestrictionModule and the SignSticker (I commented those on the commit), could you fix those too? :) (As well as revert the array syntax change)

Krakenied commented 2 years ago

The one in PriceRestrictionModule is not missing https://github.com/ChestShop-authors/ChestShop-3/blob/16515aaba442dd3a38d8baa10a719513424dc7a0/src/main/java/com/Acrobot/ChestShop/Listeners/Modules/PriceRestrictionModule.java#L117

Krakenied commented 2 years ago

I think we should fix it too: https://github.com/ChestShop-authors/ChestShop-3/blob/e40b5567b87617c432e65c84f9d1a03d4d9ae81b/src/main/java/com/Acrobot/ChestShop/Listeners/Block/SignCreate.java#L34

Phoenix616 commented 2 years ago

The one in PriceRestrictionModule is not missing

https://github.com/ChestShop-authors/ChestShop-3/blob/16515aaba442dd3a38d8baa10a719513424dc7a0/src/main/java/com/Acrobot/ChestShop/Listeners/Modules/PriceRestrictionModule.java#L117

You are right, not sure how I missed that.

I think we should fix it too:

https://github.com/ChestShop-authors/ChestShop-3/blob/e40b5567b87617c432e65c84f9d1a03d4d9ae81b/src/main/java/com/Acrobot/ChestShop/Listeners/Block/SignCreate.java#L34

Good catch.

Krakenied commented 2 years ago

revert the array syntax change

done

Phoenix616 commented 2 years ago

Thank you!