ChestShop-authors / ChestShop-3

ChestShop - the chest & sign shop plugin for Minecraft Servers running Bukkit/Spigot/Paper
https://dev.bukkit.org/projects/chestshop
GNU Lesser General Public License v2.1
272 stars 178 forks source link

Please add DiscordSRV as SoftDepend. #528

Closed andrewkm closed 1 year ago

andrewkm commented 1 year ago

What is happening?

[ChestShop] Loaded class org.slf4j.impl.StaticLoggerBinder from DiscordSRV v1.26.0-SNAPSHOT which is not a depend or softdepend of this plugin.

What did you expect to happen?

No Warning.

Plugin Version

Latest

Plugin Config

N/A

Server Version

N/A

Server Log

N/A

What other plugins are you running?

N/A

Agreements

Additional context

N/A

Phoenix616 commented 1 year ago

ChestShop has nothing to do with DiscordSRV, setting it as a soft-dependency would not make sense here. This error itself is down to your server not properly prioritising the classes and for some reason loading a class from a third-party plugin which is not in the dependency tree instead of using the one shipped with the server itself so this would need to be fixed in the server (or DiscordSRV), not in every plugin that might run into this bug.