Trigger transaction message from CurrencyTransferEvent and consider tax - Githubissues

ChestShop-authors / ChestShop-3

ChestShop - the chest & sign shop plugin for Minecraft Servers running Bukkit/Spigot/Paper

https://dev.bukkit.org/projects/chestshop

GNU Lesser General Public License v2.1

272 stars 178 forks source link

Trigger transaction message from CurrencyTransferEvent and consider tax #534

Closed felipefoschiera closed 1 year ago

felipefoschiera commented 1 year ago

Changes

Change trigger of TransactionMessageSender to be from a CurrencyTransferEvent, instead of TransactionEvent (which creates it)
Wrap original TransactionEvent inside of CurrencyTransferEvent
Use amounts from TransactionEvent (which considers tax) on the message, depending on whether the player is the buyer or seller
Remove deprecated CurrencyTransferEvent constructor

Test

Ran mvn clean install and used the plugin on a local Spigot server.

Created a shop with a product for $5k, and a defined tax of 10%.

Case 1: tax applies (for both users)

Buy mode - customer (buyer) pays $5k, shop owner (seller) receives $4.5k
Sell mode - shop owner (buyer) pays $5k, customer (seller) receives $4.5k

Case 2: NoTax permissions apply (for both users)

Buy mode - customer (buyer) pays $4.5k, shop owner (seller) receives $4.5k
- This is the logic from TaxModule#onCurrencyTransfer where it "reduces paid amount as the buyer has permission to not pay taxes"
Sell mode - shop owner (seller) pays $5k, customer (seller) receives $5k

felipefoschiera commented 1 year ago

Not sure how to link this to the issue - https://github.com/ChestShop-authors/ChestShop-3/issues/526

felipefoschiera commented 1 year ago

That makes sense. Done.