search

ChestShop-authors / ChestShop-3

ChestShop - the chest & sign shop plugin for Minecraft Servers running Bukkit/Spigot/Paper
https://dev.bukkit.org/projects/chestshop
GNU Lesser General Public License v2.1
272 stars 178 forks source link

aa #547

Closed Sitmobedaf closed 1 year ago

Sitmobedaf commented 1 year ago

bb

Phoenix616 commented 1 year ago

That's not really a fix for the issue itself... the AuthMeListener should be updated to work with the latest version, not just the error caught and ignored without any information at all to the user.

Also please use proper PR and commit messages...

Sitmobedaf commented 1 year ago

Then fix its non-disableable. I have Autnte 3.1.1 or a completely different plugin but called AuthMe. It's wrong that it immediately tries to connect to Api v3 without checking. Why not v2 or v1? if (!Properties.AUTHME_HOOK) { Plugin authMe = getServer().getPluginManager().getPlugin("AuthMe"); if (authMe != null && authMe.isEnabled()) { registerEvent(new AuthMeChestShopListener()); } }

Phoenix616 commented 1 year ago

Well the aim is to be compatible with the latest version. If the error is that the latest version doesn't work properly then that can of course be fixed.

Being compatible with plugins that wrongly identify as AuthMe isn't really possible though. They need to make sure to provide a compatible API in that case. You are kinda right though that all dependency integrations should probably fail less loudly (just with an error message) so if you want to expand the PR to catch errors with the enabling of all dependencies I would be willing to accept it, otherwise I will try to add that (and maybe even a more advanced hooking mechanism) eventually.

Sitmobedaf commented 1 year ago

Yes, add these 2 f_____g lines of code so that I have a working plugin. It hasn't worked for me for half a year now. Do it right now.

Phoenix616 commented 1 year ago

Yeah, no, that's not how this is going to go. Feel free to open a new PR if you have decided to be productive and civil about it...

Sitmobedaf commented 1 year ago

What? Did I offend you? It's all a text translator! But okay, I'll do it just for myself.