InventoryHolder couldBeShopContainer check - Broke double chest quantity updating. - Githubissues

ChestShop-authors / ChestShop-3

ChestShop - the chest & sign shop plugin for Minecraft Servers running Bukkit/Spigot/Paper

https://dev.bukkit.org/projects/chestshop

GNU Lesser General Public License v2.1

269 stars 175 forks source link

InventoryHolder couldBeShopContainer check - Broke double chest quantity updating. #568

Closed andrewkm closed 9 months ago

andrewkm commented 9 months ago

What is happening?

This commit https://github.com/ChestShop-authors/ChestShop-3/commit/a9cb8096e6bd7145363f767b2089d11d7d1ef82f broke double chest quantity updating.

This build & below works: https://ci.minebench.de/job/ChestShop-3/395/ This build & above borked: https://ci.minebench.de/job/ChestShop-3/397/

TL;DR:

Make chestshop single chest, add stuff, quantity updates.
Make chestshop double chest, add stuff, quantity doesn't update.

Video TL;DR: https://www.youtube.com/watch?v=rO2FHcUVyKI

Report made via: https://ecocitycraft.com/forum/threads/.223761/

What did you expect to happen?

Quantity to update.

Plugin Version

Latest, compiled against https://github.com/ChestShop-authors/ChestShop-3/commit/a413e86ccf8ece76f4be22da5d44b2707112c474

Plugin Config

Not needed.

Server Version

Paper 1.20.1 Build 196

Server Log

Not needed.

What other plugins are you running?

Not needed.

Agreements

[X] I have checked if there are already similar issues open.
[X] I am running the latest development version available from https://ci.minebench.de/job/ChestShop-3/.
[X] The version has support for this type of issue.
[X] I have provided all requested information and agree to the terms of the project's license

Additional context

Not needed.

andrewkm commented 9 months ago

Confirmed fixed, thanks for quick response as always. <3