ChestShop-authors / ChestShop-3

ChestShop - the chest & sign shop plugin for Minecraft Servers running Bukkit/Spigot/Paper
https://dev.bukkit.org/projects/chestshop
GNU Lesser General Public License v2.1
269 stars 175 forks source link

Problems with some Applied Energistics items #584

Open burdoto opened 4 months ago

burdoto commented 4 months ago

What is happening?

ChestShop does not generate Item Names for only some AE2 items, while some items work fine. grafik

What did you expect to happen?

ChestShop should find an item name successfully

Plugin Version

3.12.3-SNAPSHOT (build 403)

Plugin Config

config.yml

Server Version

arclight-1.20.1-1.0.4-fd335c1 (MC: 1.20.1) (Implementing API version 1.20.1-R0.1-SNAPSHOT)

Server Log

latest.log

What other plugins are you running?

grafik

Agreements

Additional context

I understand there might be limited support for this since mods are active as well; but since a component as rudimentary as name generation seems to be affected, I was hoping to still get some help for this.

Note that some Items also cause this exception, but do not seem to impair plugin functionality.

Phoenix616 commented 4 months ago

Well, those names are simply too complex to generate simple names from. Only vanilla items can be tested with at built so this is unfortunately be bound to happen when adding custom items :/

Not sure if this can be supported automatically, try using the alias config file to manually create short names for those. (You can find the item id in the error message in your log)

burdoto commented 4 months ago

I will definetely try that, thanks. Also since the names are simply very complex, how about allowing some item IDs to be fetched from a "wildcard" name for sell-only shops? In our case, shops are automatically refilled with the correct item either way; and allowing this for certain items would simplify the process.

Phoenix616 commented 4 months ago

Wildcards are unfortunately rather complex to implement with how the plugin was designed see #471