search

ChestShop-authors / ChestShopNotifier

Bukkit plugin that allows your players to see who bought or sold what while they were offline.
https://www.spigotmc.org/resources/chestshopnotifier.30313/
10 stars 8 forks source link

/Csn clear not working #22

Open Castiella opened 5 years ago

Castiella commented 5 years ago

When a player does /csn clear, it will clear the history. However, if they leave the server, the history is still there when they re-join.

Here is a latest log, which should include me testing this. I am also using paper 1.13.1 (build 229)

let me know if latest.log you need any information.

Phoenix616 commented 5 years ago

Please test with the latest development build and see if it still happens with that.

Castiella commented 5 years ago

Still happening with the recent build

Castiella commented 5 years ago

any update on this?

TheoRetisch1 commented 5 years ago

It works for me using 1.3.0-SNAPSHOT (build#35) PaperSpigiot 1.12.2 #1574 Just saw this issue because I faced the same problem before updating.

Castiella commented 5 years ago

Im using 1.13, not 1.12 - the plugin works fine on 1.12

Phoenix616 commented 5 years ago

It is working for me on 1.13. I've found another bug though which might be the behaviour that you are noticing? Please test the latest dev build.

Castiella commented 5 years ago

Using latest dev build and still having this error.

mare-on commented 3 years ago

Using the latest build and have the same issue. I will look at the code, maybe I will find where is the problem.

mare-on commented 3 years ago

The issue is in file Clear.java on line "statement.executeUpdate("DELETE FROM csnUUID WHERE Unread='1' AND ShopOwnerId='" + senderId.toString() + "'");" Where Unread='1' is wrong, it must be Unread='0'

Phoenix616 commented 3 years ago

I'm pretty sure Unread='1' is correct there as the command should only remove read entries, not unread ones. (If it's 0 it means that it hasn't been read with /csn history yet and yes, the naming is unfortuantely backwards to what one would expect)

mare-on commented 3 years ago

Ok... it's weird... it didn't work but now it works good... hmm... I will be watching it but for now looks like evething is fine idk how.

PlayingWithPi commented 2 years ago

Did this get resolved @mare-on @Castiella ? Do you still have this issue?

Laukage commented 1 year ago

Not working on Build 51, latest versions are not working that great with chestshop which is why i'm on build 51. image

Phoenix616 commented 1 year ago

@Laukage What do you mean? The latest builds work completely fine. I run them on my server. If you are having problems with it then please open issues!

As for issues with the clean command here: Please test on the latest build and if you are still experiencing issues with it then provide the following information: